Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail on NULL engine #1248

Merged
merged 7 commits into from
Feb 11, 2025
Merged

Fail on NULL engine #1248

merged 7 commits into from
Feb 11, 2025

Conversation

topepo
Copy link
Member

@topepo topepo commented Feb 1, 2025

Closes #1242

During our cli upgrades, we now fail (not gracefully) when NULL is passed as an engine.

This PR fails with a nice error message.

@topepo topepo marked this pull request as ready for review February 1, 2025 14:28
@topepo topepo requested a review from simonpcouch February 10, 2025 17:45
@topepo topepo mentioned this pull request Feb 10, 2025
Open
simonpcouch
simonpcouch approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤌

R/engines.R Outdated Show resolved Hide resolved
tests/testthat/_snaps/args_and_modes.md Outdated Show resolved Hide resolved
@topepo topepo merged commit 1880a48 into main Feb 11, 2025
12 checks passed
@topepo topepo deleted the null-engine branch February 11, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpcouch simonpcouch simonpcouch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NULL engines
2 participants
@topepo @simonpcouch